RocketChat / RocketChat/Rocket.Chat
admin's ability to create/update users allows multiple clicks on save button resulting in unhandled loading state of save button
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
admin's ability to create/update users allows for multiple clicks on the save button, resulting in a suboptimal UX
Steps to reproduce:
- Go to the admin panel section
- Navigate to the user's tab
- Create a new user or select an existing user to update.
- Fill in the necessary details or modify existing information.
- Click the save button multiple times, rapidly.
https://github.com/RocketChat/Rocket.Chat/assets/68157847/5b3abe0e-fe74-4d22-a3b1-91d8ec6d9e70
Expected behavior:
save button should be disabled if the create/update user API is in a pending state
Setup Information:
- Chrome
- Operating System: macOS
- Version - 6.7.0-develop
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the admin panel's Users tab and trace the create/update user API flow used by the save button. Reproduce rapid clicks, then verify that the button is disabled while the request is pending and that create and update actions both return to a usable state afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100