RocketChat / RocketChat/Rocket.Chat

Incorrect name displayed by rocket.cat bot when archiving or unarchiving discussions using slash commands

Open
#31,730 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Issue(s)

While using slash commands /archive and /unarchive to archive and unarchive discussions, after successfully archiving or unarchiving, rocket.cat bot displays incorrect name which can be misleading. Since we can have multiple discussions with same name within a channel, the ids displayed instead of name was to uniquely identify each discussion. However, in my opinion notifying users with the id of that discussion is not a feasible solution.

Supporting proof

https://github.com/RocketChat/Rocket.Chat/assets/69050987/ee4227cd-29ce-4167-a4f6-d0d30679256c

Steps to reproduce

  1. Goto any room other than the Discussion room which you want to archive
  2. Try typing /archive #discussion_name in the chat
  3. rocket.cat bot displays successfully archived but with a incorrect name, specifically the _id of that discussion room
  4. Similarly try the steps for /unarchive #discussion_name

Attached PR #31729

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the /archive and /unarchive steps in a room containing discussions, then trace the slash-command handling and rocket.cat response. Done means both successful responses display the discussion name rather than its _id, including when duplicate discussion names exist.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.