RocketChat / RocketChat/Rocket.Chat

Stuck when clicking download link of file

Open
#31,709 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When you click on the download link of a file someone sent you, it redirects to the file URL of the remote storage. Now you are stuck on this page with no simple way to go back to the chat. In the browser you can simply go back in history, but in the desktop app the only way to go back is to use the shortcut Alt + Left arrow. But most users will simply restart the app.

Steps to reproduce:
  1. Sent or receive a file
  2. Click on the download button of this file
Expected behavior:

I would expect the file to just download to my device.

Actual behavior:

You are redirected to the URL in Google Cloud Storage.

Server Setup Information:

Deployment

  • Version: 6.5.3
  • Apps Engine Version: 1.41.0
  • Node Version: v14.21.3
  • MongoDB: 6.0.7 / wiredTiger (oplog Enabled)
  • Commit Details: HEAD: (726574cfe)
Client Setup Information
  • Both browser and desktop app (3.9.12)
  • (EndeavourOS) Linux 6.7.4 - Gnome 45.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the file download button or link in the browser and desktop app, focusing on how the remote Google Cloud Storage URL is handled. Confirm the fix by downloading the file without navigating away from the chat, covering both clients.

Written by the indexing model from the issue text.

Assessment

Tech stack
google-cloud, typescript
Domain
cloud, desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.