RocketChat / RocketChat/Rocket.Chat
Profile image show save although not changed
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
If we click on default image although it's already default still save button is shown
https://github.com/RocketChat/Rocket.Chat/assets/133019575/f9e7fb22-0d3e-4c01-aa98-09b35a273e33
Steps to reproduce:
- Go to 'profile'
- Click on 'click on default option'
- every time click on default image it shows change save button although image is same
Expected behavior:
- If image is same it should not show save button
Actual behavior:
- showing save button whilst no change is being made
Server Setup Information:
- Version of Rocket.Chat Server: 6.x
- Operating System: win 10
- Deployment Method: browser production
- Number of Running Instances: 1
- DB Replicaset Oplog: enabled
- NodeJS Version: 14
- MongoDB Version: 6
Client Setup Information
- Desktop App or Browser Version:browser
- Operating System:win 10 64x
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue on the profile page in a browser: select the already-active default image and observe the save button. The fix is done when selecting the unchanged default image does not show a save action, while selecting a different image still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100