RocketChat / RocketChat/Rocket.Chat

Close btn not showing on E2E banner

Open
#31,628 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:
Steps to reproduce:
  1. Go to 'rc home page '
  2. If the E2E popup is there' You will not see any close btn'
  3. Click and enter some wrong code now you can see ' close ' btn

https://github.com/RocketChat/Rocket.Chat/assets/133019575/c318e3e2-ee65-4e93-bd60-8c9f82bab2fc

Expected behavior:
  • Should show the close btn there at first
Actual behavior:
  • only get close btn after getting an attampt wrong
Server Setup Information:
  • Version of Rocket.Chat Server: 6.6.0-develop
  • Operating System: win 10
  • Deployment Method: wsl2 ubuntu
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: 14.21.4 - x64
  • MongoDB Version: 6.03
Client Setup Information
  • Desktop App or Browser Version: browser
  • Operating System: win 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is identified. Reproduce the E2E popup on the Rocket.Chat home page in a browser, then trace the popup UI to find why the close button appears only after an incorrect code attempt. Done means the close button is visible when the popup first opens and the relevant browser behavior is covered by a test if one exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.