RocketChat / RocketChat/Rocket.Chat
Invalid Room for Incoming WebHook Integration
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
It seems, that umlauts are not allowed for the WebHook Integration (anymore). We had a room it was called "Tagesgeschäft", I wanted to update the WebHook Integration, but I got the message "Invalid Room". I can just save the changes if I call the room "tagesgeschaeft", but this won't match the origin room name (Tagesgeschäft).
Steps to reproduce:
- Workspace -> Integrations -> Incoming WebHook Integration
- New or existing WebHook Integration
- Post to Channel: "#Tagesgeschäft"
- save
Expected behavior:
I can save without error message "invalid room"
Actual behavior:
Server Setup Information:
+-----------------------------------------------+
| SERVER RUNNING |
+-----------------------------------------------+
| |
| Rocket.Chat Version: 6.4.1 |
| NodeJS Version: 14.21.3 - x64 |
| MongoDB Version: 6.0.11 |
| MongoDB Engine: wiredTiger |
| Platform: linux |
| Process Port: 3000 |
| Site URL: unrecognizable |
| ReplicaSet OpLog: Enabled |
| Commit Hash: 232434c5a3 |
| Commit Branch: HEAD |
| |
+-----------------------------------------------+
Client Setup Information
- Desktop App or Browser Version: 3.9.10
- Operating System: Win 11 (Version 10.0.22621 Build 22621)
Additional context
Relevant logs:
{"level":40,"time":"2024-01-02T08:10:06.515Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:10:23.634Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:10:48.358Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:10:51.358Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:10:54.181Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:11:28.554Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:16:10.786Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:18:10.614Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
{"level":40,"time":"2024-01-02T08:18:13.847Z","pid":1,"hostname":"48acdf6e196b","name":"DeprecationWarning","section":"API","msg":"The parameter \"query\" in the endpoint \"/api/v1/integrations.list\" is deprecated and will be removed on version 7.0.0"}
only the deprecation warning exists.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Workspace > Integrations > Incoming WebHook Integration and reproduce the validation failure with #Tagesgeschäft. Trace the room-name validation used when saving an incoming WebHook integration; done means a channel containing an umlaut can be saved and still resolves to the original room.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100