RocketChat / RocketChat/Rocket.Chat

Citations not deleted when user is deleted

Open
#31,194 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Messages of a deleted user are still present in citations after deleting the user. Along with their name / username.

2023-12-08_19-04
2023-12-08_19-01

Steps to reproduce:
  1. As user A go to any channel and post a message, i.e. "This text should disappear with me".
  2. As user B go to the same channel, post another message citing user A's message.
  3. Delete user A from the RC instance.
Expected behavior:
  1. All messages of user A should be deleted.
  2. The citation should be replaced with a notice that the user was deleted.
Actual behavior:
  1. All top-level messages of user A are deleted.
  2. The citation is still present along with the deleted user's name / username.
Server Setup Information:
  • Version of Rocket.Chat Server: 6.5.0
  • Operating System: Ubuntu Linux 20.04 LTS
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v14.21.2
  • MongoDB Version: 5.0.15 / wiredTiger (oplog Aktiviert)
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context
Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with two users: post a message, cite it from another account, then delete the original user. Trace the deletion and citation behavior using the reproduction steps in the issue. Done means the original messages are removed and the citation shows a deleted-user notice without the former name or username.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.