RocketChat / RocketChat/Rocket.Chat

addAction method from client/views/room/lib/Toolbox/index.tsx not present since 6.4.0

Open
#30,871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Prior to version 6.4.0 the addAction method was exported in /client/views/room/lib/Toolbox/index.tsx. This method allowed to add more buttons into the room header toolbox. But this file is not present anymore.

Steps to reproduce:
  1. Have a custom JS script with this import: const { addAction } = require('/client/views/room/lib/Toolbox/index.tsx');
  2. Open a room
  3. JS error appears in the developers console
Expected behavior:

The file exists, the method can be instantied and called properly.

Actual behavior:

url_common.js:80 Uncaught Error: Cannot find module '/client/views/room/lib/Toolbox/index.tsx'

Server Setup Information:
  • Version of Rocket.Chat Server: 6.4.5
  • Operating System: Debian 11
  • Deployment Method: tar
  • Number of Running Instances: 4
  • DB Replicaset Oplog: wiredTiger (oplog Enabled)
  • NodeJS Version: 14.21.3
  • MongoDB Version: 5.0.22
Client Setup Information
  • Desktop App or Browser Version: Browser
  • Operating System: Mac OS X
Additional context

I'm trying to search where this method has been moved to... But no clue where it has gone.

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the repository history for client/views/room/lib/Toolbox/index.tsx and tracing the current room header toolbox entry point. Confirm where addAction went or whether the old import path needs compatibility support; done means the reported custom import can instantiate and call the method without the module error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.