RocketChat / RocketChat/Rocket.Chat
Mentions do not include @all and @here
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
The list of mentions within channels do not include messages using @all and @here.
Steps to reproduce:
- Make sure you have two users who are joined to a channel.
- Log in with one user who has the permission to use
@all. - Write a message highlighting all users in the channel using
@all. - Log in with the other user.
- Open the list of mentions for the channel.
Expected behavior:
The message from step 2 is included.
Actual behavior:
The message from step 2 is not included.
Server Setup Information:
- Version of Rocket.Chat Server: 6.4.4
- Deployment Method: Docker
- Number of Running Instances: 1
- MongoDB Version: 6.0.11
Client Setup Information
Problem should be client agnostic, but tested with:
- Browser Version:
- Firefox 119.0 (64-bit)
- Chromium Version 119.0.6045.59 (Offizieller Build) Arch Linux (64-Bit)
- Operating System: Arch Linux
Additional context
It is possible to argue that the "Mentions" should only list all messages in which the user has been explicitely highlighted. However, I doubt that this is the main use case for "Mentions". At least I would prefer it to list all messages that highlighted me in some way, i.e. all messages that I receive notifications for.
Custom highlights are also not listed in "Mentions".
The mobile app behaves in the same way as the browser version.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by posting an @all or @here message in a channel, then open that channel's Mentions list as another user. Trace the code that retrieves and displays channel mentions; done when messages containing these mentions appear in the list, including in the browser and mobile-client behavior described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100