RocketChat / RocketChat/Rocket.Chat

Wrong aspect ratio of portrait images in link previews in Firefox

Open
#30,792 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

The aspect ratio of portrait images in link previews in Firefox is wrong.

Steps to reproduce:
  1. Compose a message containg a link to an image in portrait orientation, e.g. https://oekastatic.orf.at/static/images/site/oeka/20111145/tu2.5018694.jpg
Expected behavior:

The aspect ratio of the image in the link preview is correct.

Actual behavior:

The aspect ratio of the image in the link preview is incorrect.

image

Server Setup Information:
  • Version of Rocket.Chat Server: 6.4.4
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • MongoDB Version: 6.0.11
Client Setup Information
  • Browser Version: Firefox 119.0 (64-bit)
  • Operating System: Arch Linux
Additional context

There are open issues regarding aspect ratios of attached images (#23649, #20546) which might be related. However, I did not find anything about the aspect ratio of images in link previews.

When using chromium, the aspect ratio is correct:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Firefox 119 or later with the portrait image URL from the report, then compare the link preview with Chromium. Trace the frontend link-preview image rendering and verify that the displayed aspect ratio matches the source image in Firefox without regressing Chromium behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.