RocketChat / RocketChat/Rocket.Chat
Setting "Embed Ignored Hosts" ignores subdomains
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
The setting "Embed Ignored Hosts" ignores subdomains completly.
For example http://blub.domain.com/test.html gets always embeded regardless if I am add blub.domain.com or domain.com to the list. So it is not possible to block anything that has an subdomain in its url.
Description:
Steps to reproduce:
- add business.amazon.com and/or amazon.com to the Embed Ignored Hosts list
- post that link
https://business.amazon.com/en/work-with-us/commercial/agribusiness - link still gets embeded instead of ignored
Expected behavior:
Link gets ignored and no media gets embeded.
Server Setup Information:
- Version of Rocket.Chat Server: 6.4.2
- Problem exist at least since 6.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests, so start by tracing the Embed Ignored Hosts setting and the URL host-matching path used for link previews. Reproduce the listed business.amazon.com and amazon.com cases, then add coverage showing that matching hosts and subdomains remain unembedded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100