RocketChat / RocketChat/Rocket.Chat
Using Apps-Engine IRoomBuilder to rename room does not trigger callbacks
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
When modifying room from Apps-Engine IRoomBuilder, it calls
This bypasses all hooks leaving client possibly in undesirable state.
This should call saveRoomSettings as api call does.
For example is you rename room, User will continue to see old room in sidebar list and navigating to it gives error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in apps/meteor/app/apps/server/bridges/rooms.ts at lines 118-138 and compare the IRoomBuilder room-modification path with the API path that calls saveRoomSettings. Trace the callback behavior for a room rename; done means the Apps-Engine change triggers the same hooks so the sidebar and room navigation receive the updated name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100