RocketChat / RocketChat/Rocket.Chat
Emoji suggestion overriding the actual intent in input textarea
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Search before asking
- I had searched in the issues and found no similar issues.
Operating System
- macOS
- Windows
- Linux
Operating System Version
Windows 10
It happens on the web browser too?
Yes, it happens on the web browser too
Rocket.Chat Desktop App Version
3.9.9 (and also 3.1.1)
Rocket.Chat Server Version
6.2
Describe the bug
Instead of the intended emoji 😀, I end up with :fleur-de-lis: text (corresponding to ⚜)
This is just too annoying. In other languages, different emojis end up in the suggestion.
This is even worse when I try to edit the message afterwar sending it - I'm unable to close the autosuggestion with Esc key, becaus the Esc key terminates the editing.
How to Reproduce
Type :-D at the end of any message and pres the Enter key
Describe your Expected behavior
I expect the suggestions to only trigger if arrow keys are used and one is selected or Tab key are preseed, not when I hit Enter key which is used to send the message.
Anything else
No response
Are you willing to submit a code contribution?
- Yes, I am willing to submit a Pull Request!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the message input's emoji-suggestion handling and reproduce the issue by typing :-D and pressing Enter, including while editing an existing message. Done means Enter sends the message without accepting an unselected suggestion, while arrow-key or Tab selection still works and Esc remains usable during editing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100