RocketChat / RocketChat/Rocket.Chat
Upstream bug: Meteor at 2.13.* incompatible with mup deploy
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
mup deploy fails with RocketChat 6.4.0 because of a meteor bug.
NODE_VERSION=14.21.4
[...]
The command '/bin/sh -c bash ./scripts/onbuild-node.sh' returned a non-zero code: 3
A general meteor fix is available in meteor 2.13.3 according to https://github.com/meteor/meteor/issues/12732, but still pending for the meteor docker image used by mup https://github.com/zodern/meteor-docker/pull/34 .
Steps to reproduce:
- Run mup deploy
Expected behavior:
No error occurs during mup deploy
Actual behavior:
mup deploy --cached-build
Not building app. Using build from previous deploy at
/var/folders/nc/rwzmd9256tnbtt6mgbzhgtwc0000gn/T/mup-meteor-1d15c31d-e993-48d6-a171-1895776c0575
Started TaskList: Pushing Meteor App
[deploy-server] - Pushing Meteor App Bundle to the Server
[deploy-server] - Pushing Meteor App Bundle to the Server: SUCCESS
Started TaskList: Prepare App Bundle
[deploy-server] - Prepare Bundle
[deploy-server] x Prepare Bundle: FAILED
------------------------------------STDERR------------------------------------
------------------------------------STDOUT------------------------------------
Updating base image
root: Pulling from zodern/meteor
Digest: sha256:0a2d5104d177d06131b39d7321e2edd8ecd301d438c188e55d9ac173c0ab10fb
Status: Image is up to date for zodern/meteor:root
docker.io/zodern/meteor:root
Preparing for docker build
Creating Dockerfile
Finished creating Dockerfile
Building image
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
BuildKit is currently disabled; enable it by removing the DOCKER_BUILDKIT=0
environment-variable.
Sending build context to Docker daemon 1.376GB
Step 1/8 : FROM zodern/meteor:root
# Executing 6 build triggers
---> Using cache
---> Using cache
---> Using cache
---> Running in afcd976aa2b0
NODE_VERSION=14.21.4
The command '/bin/sh -c bash ./scripts/onbuild-node.sh' returned a non-zero code: 3
real 1m2.825s
user 0m7.917s
sys 0m11.590s
------------------------------------------------------------------------------
Workaround
Downgrade to meteor 2.12
cd apps/meteor
meteor update --release 2.12
Server Setup Information:
- Version of Rocket.Chat Server: 6.4.0
- Operating System: Linux
- Deployment Method: docker
- Number of Running Instances: 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the apps/meteor release and reproduce the mup deploy failure at the Prepare Bundle step. Read the linked Meteor issue and zodern/meteor-docker pull request to determine whether the used image contains the fix; done means deployment completes without the onbuild-node.sh error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100