RocketChat / RocketChat/Rocket.Chat

externalCommand 'go' does not work properly

Open
#30,384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

externalCommand 'go' does not work properly after I click quoting messages. clicking quoting messages fires chat.getMessage and i guess it puts query param the end of url in rocket.chat.
by the way, when i try to open the room which i have already opened before, externalCommand 'go' works well. that's why i click twice to open the room, it works.

Steps to reproduce:
  1. click on quoting message which calls 'chat.getMessage'
  2. open other room with externalCommand: 'go'
  3. it does NOT go to the room which I want to open but return to previous room which I click the quotes
  4. if i try once more to open the room, it opens properly.
Expected behavior:

it has to open the other room

Actual behavior:

it returns back to previous room and fires chat.getMessage api

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the sequence involving a quoted message, chat.getMessage, and externalCommand 'go'. Trace the navigation state between the quoted-message room and the requested room, then verify that opening another room selects the requested room on the first attempt without returning to the previous room or firing chat.getMessage again.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.