RocketChat / RocketChat/Rocket.Chat
The save button in the profile page should change to loading state when it is submitting for better UX
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description: The save button in the profile page should change to loading state when it is submitting for better UX.
Steps to reproduce:
- Go to Profile, make any changes for the save button to appear.
- Click the save Save button.
- Without a loading state, it is difficult for the user to understand whether the changes are being saved or any problem has occurred.
Expected behavior: The button should show a loading state when the form is submitting and should get disabled.
Actual behavior: It gives no feedback to the users.
Server Setup Information:
- Version of Rocket.Chat Server:
- Operating System:
- Deployment Method:
- Number of Running Instances:
- DB Replicaset Oplog:
- NodeJS Version:
- MongoDB Version:
Client Setup Information
- Desktop App or Browser Version:
- Operating System:
Additional context
Relevant logs:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the profile page and follow the save form submission path. Reproduce the issue by changing a profile value and clicking Save, then verify that the button shows a loading state and is disabled until submission completes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100