RocketChat / RocketChat/Rocket.Chat

Images uploaded to threads are not shown in channel message

Open
#29,909 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

message rendering type: improvement
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Uploading an image to a thread while using the "Also send to channel", the message does not show up (completely missing) in the channel.

This is a huge problem as users don't know what to look for because they only got notification but can't see or click on the message. Inside the thread view, it is displayed fine.

Checked the markup code and it seems the message row is absent (so it not just hidden, it's not rendered).
Also checked file upload settings and nothing seems off/wrong because it works fine just doesn't show up.

Steps to reproduce:
  1. send a message
  2. reply to it in thread
  3. upload an image to the thread while using "Also send to channel" option
Expected behavior:

the message (name of the image) shown in the channel like in pre-6.0 versions

Actual behavior:

the message is missing

Server Setup Information:
  • Version of Rocket.Chat Server: 6.2.10 (latest)
  • Operating System: Debian 11
  • Deployment Method: docker (official image)
  • Number of Running Instances: 1
  • DB Replicaset Oplog: enabled
  • NodeJS Version: 14.21.3
  • MongoDB Version: 6.0.8 / wiredTiger
Client Setup Information
  • Desktop App or Browser Version: Desktop App: 3.9.5 (latest); Browser: Chrome 115 (latest)
  • Operating System: Windows 10
Additional context
  • GridFS is used for file upload
  • This problem happened after the upgrade from 5.4 to 6.0, then persist ever since (6.1, 6.2), so it's not a new bug, long running issue.
Relevant logs:

There is no error, warning or any other suspicious relevant log (the image upload succeeds and works fine, only the render is broken).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by uploading an image in a thread with “Also send to channel” enabled, then compare the thread view with the channel view. Trace the channel message rendering path; no specific file or test is identified in the report. Done means the image message appears in the channel with its name and remains accessible, while existing uploads continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.