RocketChat / RocketChat/Rocket.Chat

Wrong initial state for login detection mails setting

Open
#29,666 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

The initial state of the setting My Account -> Preferences -> Notifications -> "Receive login detection emails" is wrong. It is shown as disabled but it is actually enabled.

After switching it on and off again, it works as expected.

Steps to reproduce:
  1. In the workspace, turn on the following settings under Settings -> Device Management
  • Enable login detection emails
  • Allow workspace members to turn off login detection emails
  1. Check the user setting under My Account -> Preferences -> Notifications -> "Receive login detection emails" -> Disabled
  2. Login using an incognito tab -> login detection mail still being sent
  3. turn on and off the user setting
  4. Login using an incognito tab -> login detection mail not being sent anymore
Expected behavior:

The initial state of the setting should be displayed correctly. (on by default)

Actual behavior:

The setting is displayed as "disabled", but mails are still being sent.

Clipboard - June 28, 2023 2_13 PM

Server Setup Information:
  • Version of Rocket.Chat Server: 6.2.8
  • Operating System: Ubuntu 20.04
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v14.21.3
  • MongoDB Version: 5.0.18
Client Setup Information
  • Desktop App or Browser Version: Chrome 114.0.5735.198
  • Operating System: Mac OS Ventura 13.4.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at My Account → Preferences → Notifications and trace the “Receive login detection emails” setting alongside the workspace Device Management options. Reproduce the disabled display and incognito login flow, then verify that the initial state matches the actual email behavior before and after toggling the setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.