RocketChat / RocketChat/Rocket.Chat

Update Custom OAuth services settings from environment variables

Open
#29,390 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

customOAuthServicesInit() function needs to be amended so that it updates custom OAuth services settings if the env variable changed.
We are packaging a RocketChat app for Cloudron.io with OIDC auth support and we aren't able to update ClientId and Client Secret using env variables if they were changed for example when a backup restored as a new RocketChat instance.

RocketChat v6.2.2

Related issue:
https://github.com/RocketChat/Rocket.Chat/issues/25157

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the customOAuthServicesInit() entry point and read how custom OAuth service settings are initialized from environment variables. Verify the behavior when ClientId or Client Secret changes after a backup restore; done means the stored settings reflect the current environment values.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.