RocketChat / RocketChat/Rocket.Chat
Search not working on post attachments
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Your Rocket.Chat version: 0.26
Search seems to be working only on the text of the post and not on anything inside an attachment.
This is quite a limitation when using integrations (e.g. - posting form gitlab on an alerting system. You want to use attachment to format the post in a readable way, using fields to better structure the data. But search does not work on the attachment so you can't search by the data in these fields).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the post-search implementation and the representation of attachment fields, then trace why only post text is searched. Check how search results are tested and add coverage for data in attachment fields. Done means searches can find values supplied inside post attachments as well as ordinary post text.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100