RocketChat / RocketChat/Rocket.Chat
file sharing being opened in the same "tab" and not in a new tab (even with target `_black`)
Open
Nobody has claimed this yet.
type: bug
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
when uploading a file (in this example pdf) and clicking on the download link it opens in the same tab
Steps to reproduce:
- upload
.pdfto channel - click in download (on the link with file name)
Expected behavior:
open in a new tab, not "locking" the app or tab to the file (having to close it using the browser's back button)
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 6.0.1
- Operating System: Linux
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: v14.21.2
- MongoDB Version: 4.4.15
Client Setup Information
- Desktop App or Browser Version: Brave (the same thing happens in the app)
- Operating System: macOS
Additional context
https://user-images.githubusercontent.com/31996/232850455-d56fd0d2-fe15-45ac-8015-0f7f75d9af17.mov
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the PDF upload and file-name download-link behavior in Brave or the desktop app, then trace the frontend entry point that renders and opens that link. Done means the file opens in a new tab while the Rocket.Chat tab remains available, including when the link uses target "_black".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100