RocketChat / RocketChat/Rocket.Chat

Invalid filename ending in .exe when downloading

Open
#28,551 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Search before asking
  • I had searched in the issues and found no similar issues.
Operating System
  • macOS
  • Windows
  • Linux
Operating System Version

Windows 10, macOS 13.2.1

It happens on the web browser too?

Yes, it happens on the web browser too

Rocket.Chat Desktop App Version

3.8.17

Rocket.Chat Server Version

6.0.0

Describe the bug

When uploading a file that is ended with .exe to a channel, the extra .dll extension is appended to the file name. This results in incorrect naming while downloading this file: filename.exe.dll
image

How to Reproduce
  1. Upload a file with the .exe extension
  2. Download the file (it will be saved with extra .dll; does not matter which type of OS or client is used)
Describe your Expected behavior

There must be no extra .dll extension

Anything else

It works as expected on Linux (both app and web browser)

Are you willing to submit a code contribution?
  • Yes, I am willing to submit a Pull Request!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by uploading a file ending in .exe and downloading it on Windows or macOS, as described in the issue. Trace the download filename handling from that reproduction; done means the downloaded file keeps its original .exe ending without an added .dll, including when downloaded through the web browser.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
desktop, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.