RocketChat / RocketChat/Rocket.Chat

Not show error message if try to create Custom Emoji without Aliases field

Open
#28,313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

in the Custom Emoji page if we try to create Custom Emoji without Aliases field it does not show error message

Steps to reproduce:
  1. in the Custom Emoji page click on the new button to create new Custom Emoji
  2. try to create Custom Emoji without fill the Aliases field
Expected behavior:

it needs to show the field required error

Actual behavior:

https://user-images.githubusercontent.com/98152507/223466582-4edd3711-99ed-4a80-b1c4-8b16c53e908c.mp4

Client Setup Information
  • Desktop App or Browser Version: firefox
  • Operating System: win 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Custom Emoji creation page and reproduce the missing validation in Firefox with the Aliases field empty. Trace the form validation for Aliases; done means submitting without an alias displays the required-field error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.