RocketChat / RocketChat/Rocket.Chat

Error editing team description

Open
#28,286 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

I already submitted an issue in the ReactNative section #4929. But there it was closed. Perhaps this is not a problem of a mobile application, but of the mechanism for converting a channel into a team.

Description:

An error occurs when trying to edit the team description from a mobile device. The problem occurs in the team converted from the channel, in addition, there must be a space in the name.

Environment Information:
  • Rocket.Chat Server Version: 5.4.2
  • Rocket.Chat App Version: latest
  • Device Name: Different on Android and iOS
  • OS Version: Different
Steps to reproduce:
  1. Create a channel with a space in the name, like "test team".
  2. Convert the channel to a team by clicking the "Convert to Team" button.
  3. Try editing the Description or Announcement field from a mobile device.
Expected behavior:

The team description can be changed from a mobile device.

Actual behavior:

An error occurs when saving changes.

https://user-images.githubusercontent.com/104189570/223030241-d0a81b80-14f5-4f3a-a6d7-6c19c8f64252.mp4

Additional context:
  • Both Android and iOS are affected by the problem.
  • The problem does not occur if there is no space in the title.
  • From a browser or desktop client, these fields can be changed.
  • Reproduced on open.rocket.chat.
    When running through the emulator, we saw this error for team with the link https://rc.example.com/group/komanda-sit:
    {"details": {"function": "RocketChat.updateRoomName", "handle": "Komanda-SIT"}, "error": "error-duplicate-handle", "errorType": "Meteor.Error", "isClientSafe": true, "message": "A room, team or user with name 'Komanda-SIT' already exists [error-duplicate-handle]", "reason": "A room, team or user with name 'Komanda-SIT' already exists"}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the conversion and edit flow described in the issue, then trace the reported RocketChat.updateRoomName error for a converted team whose name contains a space. The fix is complete when mobile users can save the Description or Announcement for that team without a duplicate-handle error, while existing browser and desktop behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.