RocketChat / RocketChat/Rocket.Chat

weird "disallowed reactions" system message when admin changes channel name

Open
#28,256 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When an admin changes the name of a channel that it is not member of, a weird "disallowed reactions" system message appears. Nevertheless reactions are possible afterwords, and there is no option in the channel settings to change if reactions are allowed or not.

Steps to reproduce:
  1. create a channel with a normal user
  2. with an admin that is not member of that channel change the name of the channel with the worspace -> Administration -> #Rooms -> -> Room Information -> Name field.
Expected behavior:

Only the name is changed.

Actual behavior:

The name is changed, and another message appears in the channel: <adminname> disallowed reactions

Server Setup Information:
  • Version of Rocket.Chat Server: 5.4.3
  • Operating System: Ubuntu
  • Deployment Method: snap
  • Number of Running Instances: 1
  • DB Replicaset Oplog: rs0
  • NodeJS Version: v14.19.3
  • MongoDB Version: 4.4.15 / wiredTiger (oplog Enabled)
Client Setup Information
  • Desktop App or Browser Version: Google Chrome 110.0.5481.177
  • Operating System: MacOS 12.6.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue through Administration → Rooms → Room Information → Name using an admin who is not a channel member. Trace the channel-name update and the system-message generation, then verify that renaming emits no unrelated “disallowed reactions” message while reactions remain available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.