RocketChat / RocketChat/Rocket.Chat

Room not found error when switching type of channel

Open
#27,879 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When changing type of channel from public to private or private to public sometimes an error occurs. it is probably because for private rooms url have group/name in it but for public it has channel/name so when updating sometimes url does not changes and hence we are directed to room not found error

Steps to reproduce:
  1. Create a channel
  2. Go to room info and then edit room info
  3. Change room type.
  4. Repeat the process one time
Expected behavior:

Home page of room should appear with changed url

Actual behavior:

Room not found error appears and url is ssame as previous

https://user-images.githubusercontent.com/114513938/215261343-57d6ad5e-3426-4660-aa25-26509c7e4248.mp4

Server Setup Information:
  • Version of Rocket.Chat Server: 5.5
  • Operating System: Ubuntu 22.04 LTS
  • NodeJS Version: v14.21.2
Client Setup Information
  • Desktop App or Browser Version:Browser Version
  • Operating System: Ubuntu 22.04 LTS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by changing a channel between public and private twice, using the listed steps and Rocket.Chat 5.5 setup details. Trace the room URL handling from the room-info edit flow; done means the room opens after each change and the URL uses the changed room type rather than showing a room-not-found error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.