RocketChat / RocketChat/Rocket.Chat

Size limit alert show only after upload process

Open
#27,785 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

If an user changes the file extension of a file to upload, let's say iso to pdf, the system accepts the upload and start to upload the file anyway, only to give the file size limit alert at the end of the process.

Files with an iso extension are set as blocked and the size limit is set to 50mb, but the alert only comes at the end of the 4gb upload process (iso renamend to pdf size example), causing the system to slow down.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Reproduce the case by renaming an ISO file to PDF, then trace the upload validation entry point and size-limit alert; done means the blocked or oversized file is rejected before its contents begin uploading.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.