RocketChat / RocketChat/Rocket.Chat

SVG favicon not always used in Chrome

Open
#26,982 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

My Rocket.Chat instance has SVG favicons enabled and an SVG favicon has been uploaded:

image

(Field descriptions are currently missing due to https://github.com/RocketChat/Rocket.Chat/issues/26502).

However, when opening Rocket.Chat in Google Chrome or Chromium, the favicon is not used from the beginning. As soon as the logo changes to the one with the green dot indicating a new message, the uploaded favicon will be used. The problem does not occur in Firefox.

Steps to reproduce:
  1. Enable SVG favicons and upload an SVG favicon.
  2. Ensure that you do not have any unread messages in any channel.
  3. Open Rocket.Chat in Google Chrome or Chromium.
  4. Wait for another user to write a new message.
  5. Mark all new messages read.
Expected behavior:

The uploaded SVG favicon is always used:

image

Actual behavior:

After step 3, the SVG favicon is not used:

image

After step 4, it is used:

image

After step 5, it is used as well:

image

Server Setup Information:
  • Version of Rocket.Chat Server: 5.1.4
  • Operating System: Debian GNU/Linux
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: ?
  • NodeJS Version: 14.19.3
  • MongoDB Version: 5.0.12
Client Setup Information
  • Desktop App or Browser Version: Chromium 106.0.5249.61 (Offizieller Build) Arch Linux (64-Bit)
  • Operating System: Arch Linux
Additional context

This problem does not occur in Firefox 105.0.1 (64-Bit):

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Chrome or Chromium with SVG favicons enabled, an uploaded SVG favicon, and no unread messages; compare the initial favicon with Firefox. Trace the favicon handling from the browser entry point and verify that the uploaded SVG is shown initially and after messages are marked read.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.