RocketChat / RocketChat/Rocket.Chat
v5.1.0 - Disable Embed for Users & Embed Ignored Hosts setting is ignored (Enterprise)
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
I had Disable Embed for Users turned off for Embed Link Previews since I remember, but after we upgraded to v5.1.0, it's no longer working.
Steps to reproduce:
- Disable Embed for Users in admin panel.
Expected behavior:
- Do not show url previews (og tags) for certain users.
Actual behavior:
- Url previews are displayed in the chat.
Server Setup Information:
- License: Enterprise
- Version of Rocket.Chat Server: 5.1.0
- Deployment Method: Docker image
- MongoDB Version: 4.4.15 / wiredTiger (oplog Enabled)
Client Setup Information
- Desktop App or Browser Version: Desktop App, 3.8.9
- Operating System: Windows 11
Additional context
- Embed Ignored Hosts setting is also ignored.
Relevant logs:
No additional logs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with Disable Embed for Users and Embed Ignored Hosts configured in the admin panel, using the reported Enterprise 5.1.0 setup. Trace the URL preview handling from the setting behavior and verify that previews are suppressed for the selected users and ignored hosts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100