RocketChat / RocketChat/Rocket.Chat

Nested Items are broken after 5.x.x

Open
#26,738 19 comments 21 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

message rendering type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

After upgred to 5.x.x nested item does not work in the main chat, but works in the [Replay in Thread] or preview in the [Quote].

Steps to reproduce:
  1. http://localhost:3000/admin/settings/Message -> Markdown -> Markdown Parser -> Marked
  2. Open #General channel
  3. Paste correct code from https://docs.rocket.chat/contributors/how-can-i-help/documentation/markdown-styleguide#md005-no-inconsistent-indentation-for-list-items-at-the-same-level
* Item 1
    * Nested Item 1
    * Nested Item 2
    * Nested Item 3 --->Aligned
  1. Get broken nested items
Expected behavior:

Correct nested items, like in the 4.x.x

Actual behavior:

изображение
изображение

Server Setup Information:
  • Version of Rocket.Chat Server: 5.0.5
  • Operating System: ubuntu
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: 14.19.3 - x64
  • MongoDB Version: 5.0.11
Client Setup Information
  • Desktop App or Browser Version: app 3.8.8, firefox 103.0.2
  • Operating System: ubuntu 22.04

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce this in #General after setting Admin > Settings > Message > Markdown > Markdown Parser to Marked, using the linked Markdown style-guide example; compare the main chat with Replay in Thread and Quote preview. Trace the message-rendering path responsible for nested list indentation and verify that nested items render correctly in the main chat as they do in 4.x.x.

Written by the indexing model from the issue text.

Assessment

Tech stack
markdown, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.