RocketChat / RocketChat/Rocket.Chat
Missing data-username attribute in main DOM message wrapper element
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
DOM data-username attribute has disappeared from rcx-message wrapper div.
Expected behavior:
Previous to v5 message DIV had the data-username attribute so we could style messages depending on the author. In v5, the rcx-message class DIV, has not this attribute so we cannot do the same thing. This attribute is present in another DIV wrappers as rcx-message-header__name or rcx-message-header__username.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 5.0.4
- Operating System: Debian 10
- Deployment Method: tar
- Number of Running Instances: 4
- DB Replicaset Oplog:
- NodeJS Version: 14.19.2
- MongoDB Version: 4.4.16
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the component that renders the rcx-message wrapper and inspect how its DOM attributes are assembled. Compare the current wrapper with the reported pre-v5 behavior, then verify in the rendered message DOM that the author-related data attribute is present and remains correct for messages from different users.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100