RocketChat / RocketChat/Rocket.Chat

SecretUrl Parameter not working on users.register endpoint

Open
#26,622 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

SecretUrl Parameter not working on users.register endpoint.

  1. When we try to pass SecretUrl as a part of users.register endpoint body it throws an error message saying "must NOT have additional properties [invalid-params]
Steps to reproduce:
  1. Send a request with SecretUrl parameter on endpoint '/api/v1/users.register'
Expected behavior:

Screenshot 2022-08-19 at 6 52 24 PM

Actual behavior:

Screenshot 2022-08-19 at 5 15 25 PM

Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a request to the users.register API endpoint with the SecretUrl parameter and compare the validation error with the expected request shown in the issue. Trace the endpoint's request validation and determine what must change so SecretUrl is accepted, then verify that the request no longer reports an additional-property error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.