Notification "@user is already is here." not translated

Open
#26,521 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Domain
localization

Research direction

Reproduce the issue using the listed room-member invitation steps with Russian selected, then trace the notification text and the Username_is_already_in_here translation key. Done means the duplicate-member notification uses the selected server language and the custom translation behavior is consistent with the supported translation format.

Written by the indexing model from the issue text.

Description

feat: i18n
Description:

When adding a user who is already in the room, a notification is displayed in English, but Russian is enabled on the server.

Steps to reproduce:
  1. Open room
  2. Click Members icon
  3. Push Invite
  4. Select exists member
  5. Get message "@User is already in here."
Expected behavior:

Message translated into the selected server language.

Actual behavior:

screenshot_21

Server Setup Information:
  • Version of Rocket.Chat Server: 4.8.1
  • Operating System: Debian GNU/Linux 10 (buster)
  • Deployment Method: docker
  • Number of Running Instances: 2
  • DB Replicaset Oplog: wiredTiger
  • NodeJS Version: v14.18.3
  • MongoDB Version: 5.0.8
Client Setup Information

Browser Version:

  • Operating System:
Additional context

I tried to add Custom translation in General settings but it doesn't work

{
	"ru": {
		"Username_is_already_in_here": "\"@%s\" уже здесь."
	}
}

screenshot_22

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat

All issues in RocketChat/Rocket.Chat

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.