RocketChat / RocketChat/Rocket.Chat
Square brackets in username breaks channels
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Some one (me) added [1337] to their username, and as a result several users had issues viewing channels where I'd posted the last message. For android app one user expereinced the app crashing when trying to open the channel in question, some had issues loading the message only seeing the username (dont know what platform he was on), and another had issues loading the channel from webapp.
I personally had no issues.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the problem with a username containing square brackets, then compare opening the affected channel in the Android app and web app. Trace the channel and message loading path from the observed failure; done means the channel and its messages load normally for users with such usernames on the affected platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- full-stack
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100