RocketChat / RocketChat/Rocket.Chat

OVERWRITE_SETTING of Jitsi App doesn't work from 5.0

Open
#26,404 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

With the change / update of video conferencing - Jitsi Settings are no longer read from environment variables.

Steps to reproduce:

Download docker container and try to start with the following environment variables:

OVERWRITE_SETTING_Jitsi_Enabled=
OVERWRITE_SETTING_Jitsi_Domain=
OVERWRITE_SETTING_Jitsi_URL_Room_Prefix=
OVERWRITE_SETTING_Jitsi_Enable_Channels=
OVERWRITE_SETTING_Jitsi_Open_New_Window=
OVERWRITE_SETTING_Jitsi_Chrome_Extension=
OVERWRITE_SETTING_Jitsi_Enabled_TokenAuth=
OVERWRITE_SETTING_Jitsi_Application_ID=
OVERWRITE_SETTING_Jitsi_Application_Secret=
Expected behavior:

When I install the Jitsi App from the new App marketplace, it should be possible to set the App settings via Environment variables, to start the docker container with the correct settings.

Bonus points, if we could install Apps like Jitsi App via an environment variable from the Marketplace, while starting the container.

Actual behavior:

Settings stay empty and need to be set by hand.

Server Setup Information:
  • Version of Rocket.Chat Server: 5.0.0
  • Operating System: Linux
  • Deployment Method: docker
  • Number of Running Instances: 2
  • DB Replicaset Oplog: enabled
  • NodeJS Version: v14.19.3
  • MongoDB Version: 4.2.21 (we know it's deprecated)
Client Setup Information

n/a

Additional context

n/a

Relevant logs:

n/a

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by starting the Docker container with the listed OVERWRITE_SETTING_Jitsi_* variables and installing the Jitsi App from the marketplace. Trace the environment-variable handling and Jitsi app settings path; it is done when the settings are populated at startup without manual configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.