RocketChat / RocketChat/Rocket.Chat

login does not redirect using invite link if user is not connected

Open
#26,244 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When sending an invite link to someone who is not currently connected to Rocket Chat the user wont be redirect after a successfully login. The page won't do anything, user has to refresh to get connected and join the channel

Steps to reproduce:
  1. Go to a channel and generate an invite link
  2. Send it to a user who is not online/connected to your rocket chat
  3. Do a successfully login => (notice nothing happens)
  4. Refresh the page then get connected and correctly join the channel
Expected behavior:

After the successfully login the user should be redirect and directly join the channel without a need to refresh

Actual behavior:

User is currently stuck to login page and need to refresh

Server Setup Information:
  • Version of Rocket.Chat Server: 4.8.1
  • Operating System: Ubuntu 20.04
  • Deployment Method: docker-compose
  • Number of Running Instances: 1
  • DB Replicaset Oplog: (oplog Enabled)
  • NodeJS Version: v14.18.3
  • MongoDB Version: 4.4.15 / wiredTiger
Client Setup Information
  • Desktop App or Browser Version: Web browser, Firefox 102 ( + User did a test using Chromium)
  • Operating System: Fedora 35
Additional context

If the user is already connected the invite link works fine. If the user remove the focus then refocus the window, the user will be redirected after the new focus

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reproducing the invite-link login flow in a web browser, then inspect the redirect behavior when the connection is established and compare it with the focus-triggered behavior described in the issue. Done means a user who logs in from an invite link is redirected and joins the channel without refreshing or refocusing the window.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.