GitHub integration calculates an invalid link when reporting a closed pull request

Open
#26,025 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
github, typescript
Domain
backend

Research direction

No file or test is named in the issue. Trace the GitHub integration path that reports a closed pull request and reproduce the malformed link shown in the report. Done means the displayed link text is only the username and the generated link is valid.

Written by the indexing model from the issue text.

Description

"https://github.com/grisumbras|grisumbras" is incorrect. The text for the link should probably be just the username ("grisumbras") instead of the full href.

image

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat

All issues in RocketChat/Rocket.Chat

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.