RocketChat / RocketChat/Rocket.Chat

Unable to login via SAML with Azure if SAML ID is generated with leading digit

Open
#26,019 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Azure validates that a SAML ID may not begin with a number.

image

When signing in with this IdP the user has to login a few times until an ID is generated that happens to begin with a letter and then it works fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the SAML login flow and the code that generates the SAML ID for Azure. Confirm the behavior with an Azure IdP whose generated ID begins with a digit; done means the ID meets Azure's validation and the user can sign in on the first attempt.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, typescript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.