RocketChat / RocketChat/Rocket.Chat

No Cyrillic folders in Webdav

Open
#26,003 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Describe the bug
When trying to send a file from the integrated webdav server (Nextcloud), directories written in Cyrillic are not displayed at the root, files written in Cyrillic are displayed without problems. I also checked in subdirectories, all folders are displayed there.

What operating system and which version? openSUSE Tumbleweed
Which version of Rocket.Chat (Server)? 4.0.0
Which version of Rocket.Chat.Electron (Electron/Desktop)? 3.5.7
Is there any setting relevant changed? No

To Reproduce

  1. Create a folder in the root with a name in Cyrillic, for example Проба
  2. Try to send it by clicking the + button and selecting the webdav server
  3. A content browsing window will open where this folder will not be visible

Expected behavior
The folder should be rendered

Log

I20211012-20:40:55.369(6) Exception while invoking method getWebdavFilePreview errorClass [Error]: Error, too many requests. Please slow down. You must wait 41 seconds before trying again. [too-many-requests]     at Object.post (app/api/server/v1/misc.js:233:11)     at app/api/server/api.js:406:82     at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)     at Object._internalRouteActionHandler [as action] (app/api/server/api.js:406:39)     at Route.share.Route.Route._callEndpoint (packages/nimble_restivus/lib/route.coffee:150:32)     at packages/nimble_restivus/lib/route.coffee:59:33     at packages/simple_json-routes.js:98:9 {   isClientSafe: true,   error: 'too-many-requests',   reason: 'Error, too many requests. Please slow down. You must wait 41 seconds before trying again.',   details: { timeToReset: 40802 },   errorType: 'Meteor.Error' } 
{"level":35,"time":"2021-10-12T14:40:55.370Z","pid":6598,"hostname":"cloud1","name":"API","method":"POST","url":"/api/v1/method.call/getWebdavFilePreview","userId":"64QtuDjKJa5HANkDh","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.164 Electron/13.2.2 Safari/537.36","length":"187","host":"chat.example.org","referer":"https://chat.example.org/direct/LXAs8ppyWAJQzici9","remoteIP":"IP","status":200,"responseTime":2} 

API_Enable_Rate_Limiter disabled
Send many messages the group the user belongs to is allowed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the getWebdavFilePreview method named in the log and reproduce the issue with a Cyrillic folder at the WebDAV root on Rocket.Chat 4.0.0. Compare root and subdirectory browsing, and check whether the rate-limiter error affects the request. Done means the Cyrillic folder is visible and selectable from the root browsing window.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.