RocketChat / RocketChat/Rocket.Chat
Trailing spaces in user input (email field) result in login error
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
When trying to log in on a new chat server, the e-mail adress fied allows spaces as a valid character.
If one writes the email-adress with a leading or trailing space, it is considered incorrect.
This is particularly problematic in mobile input, as some auto-complete keyboards insert a trailing space after emails.
Possibilities to fix it
- not accept a space as a valid character in the E-mail address field
- automatically trim spaces from the E-mail adress field
- add a warning about this bug on the login window
Entry on this issue on another forum
Best,
Al
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing login with leading and trailing spaces in the email field, then locate the login form's input handling and validation. Compare the listed options and confirm the chosen behavior for mobile keyboard-added spaces; done means valid email input with surrounding spaces no longer causes an avoidable login error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100