RocketChat / RocketChat/Rocket.Chat
Deactivated users are still visible in the "search" context
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
Deactivated users are still visible in the "search" context
Steps to reproduce:
- Deactivate a user
- Click on the "magnifier glass" to search for a user and enter his ID
- User is still visible as offline
Expected behavior:
User should not be found on search, just like they cannot be found in the directory or while adding members to a group
Actual behavior:
Not only the user is still visible, but messages can be sent to his chat channel
Server Setup Information:
- Version of Rocket.Chat Server: 4.6.3
- Operating System: Linux
- Deployment Method: docker
- Number of Running Instances: 1
- DB Replicaset Oplog:
- NodeJS Version: 14.18.3
- MongoDB Version: 4.2.18
Client Setup Information
- Desktop App or Browser Version: on any client including browser
- Operating System: on any client including browser
Additional context
I don't understand the logic of showing a deactivated user in the search and especially the possibility of sending messages to him. Deleting the user is not really an option since all their messages from all their chat rooms would be deleted. This confuses the users greatly.
If this behaviour is intentional, would there be a possibility to make it optional to "hide deactivated users from search" or similar?
Thanks in advance!
Sandro
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Reproduce the behavior by deactivating a user and searching for their ID, then compare it with directory and group-member lookup; done means the deactivated user is not returned by search and the reported chat access behavior is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- search
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100