RocketChat / RocketChat/Rocket.Chat

[4.7.0] Add user to room on "Click to Join!" button press

Open
#25,487 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Fix https://github.com/RocketChat/Rocket.Chat/issues/19420

Steps to reproduce:
  1. Start a new Jitsi call in a channel or discussion (logged in as a member of the room). Then, access the room as another user and press the "Click to Join!" button. Expected behavior: the user should join the room (if they're not already a member).
  2. Access a discussion inside a channel (public room). Expected behavior: If the user is not a member of the discussion, a "Join" button should be displayed in the message box.
Expected behavior:

Clicking the button should open the video.

Actual behavior:

I click the button and nothing happens.

Server Setup Information:
  • Version of Rocket.Chat Server: 4.7.0
  • Operating System: Ubuntu 20.04.4 LTS
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: v14.19.1
  • MongoDB Version: 5.0.8
Client Setup Information

Desktop App or Browser Version: Chrome and Desktop App for Windows
Operating System: Windows

Additional context

none

Relevant logs:

none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the "Click to Join!" button flow for Jitsi calls and the "Join" button flow in discussion message boxes. Verify the room-membership behavior for non-members and confirm that clicking the call button opens the video and displays the Join action when appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
full-stack
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.