Custom Oauth Settings are not Overwritten

Description:

We are installing Rocketchat via Helm Chart. To configure Keycloak the first time we can set the required variables using environment variables. After Deploying Keycloak all Settings are created.
We are managing the client id and secret through Kubernetes Secrets.
If we need to change these it has no effect to Rocketchat.

- name: 'OVERWRITE_SETTING_Accounts_OAuth_Custom_Keycloak_id' valueFrom: secretKeyRef: name: oauth-secret key: client_id - name: 'OVERWRITE_SETTING_Accounts_OAuth_Custom_Keycloak_secret' valueFrom: secretKeyRef: name: oauth-secret key: client_secret
I can see the secret correctly resolved in the Environment Variables of the Container but it does not change the settings.

Steps to reproduce:

1. Clone https://github.com/kubernetes/charts/tree/master/stable/rocketchat, and add the following to values.yaml:

extraEnv: |
  ...
   - name: 'OVERWRITE_SETTING_Accounts_OAuth_Custom_Keycloak_id'
      valueFrom:
        secretKeyRef:
          name: oauth-secret
          key: client_id
    - name: 'OVERWRITE_SETTING_Accounts_OAuth_Custom_Keycloak_secret'
      valueFrom:
        secretKeyRef:
          name: oauth-secret
          key: client_secret

2. Install with Helm
3. Verify that Keycloak is correctly configured.
4. Update the client Secret.
5. Update with Helm
6. Verify that the the client_id and secret have been updated with new credentials

Expected behavior:

Rocket.Chat should update the client_id and secret after changing the Settings

Actual behavior:

The Settings are not updated

Server Setup Information:

Rocket.Chat Version: 4.1.2
Operating System: Kubernetes
Deployment: Helm
Number of running Instances: 1
DB Replicaset Oplog: true
Node Version: v12.22.1
MongoDB: 4.4.6 / unknown (oplog Enabled)

Client Setup Information

• Browser Version: Chrome

Start with the Helm chart's values.yaml and the OVERWRITE_SETTING_Accounts_OAuth_Custom_Keycloak_id and secret environment variables described in the report. Trace how updated Kubernetes Secret values reach Rocket.Chat settings, then verify that a Helm update changes both credentials as expected.