RocketChat / RocketChat/Rocket.Chat
error 'Message could not be starred' appears if trying star message in thread after page reload
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
User see red error 'Message could not be starred' if he is trying to star message in the thread after page reload.
Steps to reproduce:
See the video below.
Expected behavior:
No error shown for starred/unstarred action.
Actual behavior:
User sees error "Message could not be starred" despite call to /api/v1/method.call/starMessage ends with success
Server Setup Information:
Checked on https://open.rocket.chat
Client Setup Information
-
Additional context
Video demo: https://user-images.githubusercontent.com/2260980/161398187-9c8c0d2e-588a-480c-a27b-2e304a92a392.mp4
Relevant logs:
-
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by reloading a thread, then starring or unstarring a message. Start by tracing the client handling around /api/v1/method.call/starMessage and compare the successful response with the error display. Done means starred and unstarred actions show no erroneous error after reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100