RocketChat / RocketChat/Rocket.Chat

Method logoutCleanUp request is growing up

Open
#24,981 0 comments 0 reactions 1 assignee View on GitHub

@ggazzo is already working on this.

Since Nov 25, 2022.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

I am using Rocket.Chat for an internal server with latest version on develop branch. I get an issue with the method logoutCleanUp. It sends a complete information of user through requests. As a result, if a user participates in many rooms, this request weights heavily. You can test it on https://open.rocket.chat.

Steps to reproduce:
  1. Create an account on https://open.rocket.chat
  2. Create 4 channels
  3. Inspect the browser tab (F12 in Chrome), change to Network tab
  4. Logout
  5. Continue to create 10 or 20 or 300 channels / teams
  6. Inspect the browser tab (F12 in Chrome), change to Network tab
  7. Logout
Expected behavior:

Request /api/v1/method.callAnon/logoutCleanUp header content-length should not change rapidly.

Actual behavior:

Request /api/v1/method.callAnon/logoutCleanUp header content-length changes rapidly. Request payload consists of __rooms array.

Server Setup Information:
  • Version of Rocket.Chat Server: 4.5.0
  • Operating System: Ubuntu 20.04
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: --
  • NodeJS Version: 14.18.3
  • MongoDB Version: 4.0.5
Client Setup Information
  • Desktop App or Browser Version: Browser version
  • Operating System: Ubuntu 20.04 or Windows 10 Home or Safari
Additional context

You can try it directly on https://open.rocket.chat.

Relevant logs:

You will get request log in browser tab inspector as the above steps.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.