RocketChat / RocketChat/Rocket.Chat

Link to the message teleports to wrong scroll position in Firefox browser and electron app

Open
#24,964 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Link to the message teleports user to wrong scroll position when link opened in Firefox.

Steps to reproduce:
  1. Go to https://open.rocket.chat/channel/general
  2. Press "Get Link" in the context menu of any message, you will get the link like https://open.rocket.chat/channel/general?msg=XzCNzbMHjJ9usicMg
  3. Follow link from step 2.
Expected behavior:

Firefox loads the page, set correct scroll position focused on the correct post, then highlights it with yellow.
Chrome browser is not affected at all, so you can see expected behavior there.

Actual behavior:

Firefox teleports user to the message before the page fully load, thus scroll position get changed and user can't see correct message.
Video demo: https://user-images.githubusercontent.com/2260980/160237330-5e4c8cd1-5712-4990-8571-992dc8cb572b.mp4
Sometimes it doesn't reproduce and Firefox successfully achieves teleporting to correct position, but it happens very rarely.

Server Setup Information:

Checked on https://open.rocket.chat/channel/general

Client Setup Information
  • Browser Version: Firefox 98.0.2 (tested on clean installation)
  • Operating System: Windows 10
Additional context

Discussed here: https://forums.rocket.chat/t/link-to-message-teleports-to-wrong-scroll-position-in-firefox/13623

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by opening a generated message link in Firefox and the Electron app, comparing it with Chrome. Trace the message-link navigation, loading, scroll-position, and highlight flow; done means the target message is visible, correctly positioned, and highlighted after the page finishes loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
desktop, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.