RocketChat / RocketChat/Rocket.Chat
[BUG] New user created by admin asks for verification if marked verified
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 46.1k
- Forks
- 13.9k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 130
Description
Description:
First login attempt from a new user created by admin requires verification code even if the user was marked as verified at the time of creation whereas a new user not marked as verified is not asked for a verification code.
Steps to reproduce:
- Go to Administration.
- Click on Users.
- Click on New to create new user.
- Enter required details and mark the user as Verified by clicking on the toggle switch.
- Click on Save and then logout from the admin account.
- Try logging in using the credentials of the new user just created.
Expected behavior:
A user marked as verified by the admin should be able to login directly without having to enter any verification code.
Actual behavior:
Server Setup Information:
- Version of Rocket.Chat Server: 4.6.0-develop
- Operating System: Ubuntu 20.04 running on Windows Subsystem for Linux (WSL2)
- Deployment Method:
- ReplicaSet OpLog: Enabled
- Number of Running Instances: 1
- NodeJS Version: 14.18.3 - x64
- MongoDB Version: 4.4.4
Client Setup Information
- Desktop App or Browser Version: Google Chrome Version 98.0.4758.102 (Official Build) (64-bit)
- Operating System: Windows 11
Additional context
A user not marked as verified by the admin is able to login directly without having to enter any verification code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue through Administration > Users by creating a verified user, then compare that user's first login with an unverified user's login. Trace the admin user-creation and login verification entry points; done means an admin-marked verified user can log in without a verification code while the existing behavior for other users remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100