Grouping Period will group messages of different users in DMs

Open
#24,825 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

No source file or test entry point is named in the issue. Start by reproducing the two-person DM in Chrome with grouping period set to zero and then to a nonzero value; trace the message-grouping behavior. Done means messages from different users remain in separate blocks regardless of the grouping period.

Written by the indexing model from the issue text.

Description

area: ui/ux
Description:

The "grouping period" setting clearly states:

Messages will be grouped with previous message if both are from the same user and the elapsed time was less than the informed time in seconds.

However, we have experienced this for two sets of users that are quickly chatting with each other and getting grouped.

Steps to reproduce:

Have a conversation between two people. Messages sent seconds apart.

Set Grouping Period to 0

Screenshot 2022-03-14 at 16 50 45

The messages are neatly stacked.

Untitled

Set Grouping Period to anything else

Screenshot 2022-03-14 at 16 51 16

All in one block

Untitled (1)

Expected behavior:

If another user sends a message, it should not be grouped.

Actual behavior:

It is grouped.

Server Setup Information:

Screenshot 2022-03-14 at 16 59 26

Client Setup Information
  • Desktop App or Browser Version: Browser, Chrome 99
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat

All issues in RocketChat/Rocket.Chat

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.