RocketChat / RocketChat/Rocket.Chat

2FA notification window do not popup when editing user

Open
#24,617 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When trying to edit the user, got the error message "Undefined" or the screen becomes dark, unresponsible.
The same happens via the application or via the web.

Steps to reproduce:
  1. Go to Administration -> users
  2. Try to edit any user.
Expected behavior:

2FA popup window will appear and input one-time authentication code

Actual behavior:

The screen is the dark or red message "Undefined" is displayed.

On the server`s log there is the entry:
"Exception while invoking method saveSettings 'TOTP Required [totp-required]'"}"

Server Setup Information:
  • Version of Rocket.Chat Server: 4.4.2
  • Operating System: Centos 7.9
  • Deployment Method: installation/compilation
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v14.18.2
  • MongoDB Version: 4.2.18 / wiredTiger (oplog Enabled)
Client Setup Information
  • Desktop App or Browser Version: 3.7.8, Firefox 97.01
  • Operating System: Windows
Relevant logs:

"Exception while invoking method saveSettings 'TOTP Required [totp-required]'"}"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Administration → users edit flow and the server-side saveSettings method mentioned in the report. Reproduce the issue with 2FA enabled and inspect how the 'TOTP Required [totp-required]' response is handled. Done means editing a user opens the one-time-code prompt in both the application and web interface instead of showing 'Undefined' or a dark screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
authentication, backend, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.