RocketChat / RocketChat/Rocket.Chat

[BUG] Allowing Administrator To Edit App

Open
#24,548 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

Is there a point to allow administrators to edit any apps inside the user tab?

Steps to reproduce:
  1. Go to the Admin tab
  2. Go to users
  3. If you already installed any apps then you will find apps inside the user section
  4. It allows to edit the apps also
Expected behavior:

I think we should disable the edit button for the apps(.bot). There is no sense to provide an edit option or else some fields should need to be disabled. for example

  1. Admin can change the bot name and some other fields
  2. should disable email, role, password, etc.
Actual behavior:

It's allowing the administrator to edit the app.

https://user-images.githubusercontent.com/53515714/154800811-ef79a036-2c76-4cef-8d22-cf2ded389d7a.mp4

Server Setup Information:
  • Version of Rocket.Chat Server: 4.5.0
  • Operating System: Windows 10
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version: 14.18.3
  • MongoDB Version: 4.4.4
Client Setup Information
  • Desktop App or Browser Version:
  • Operating System:
Additional context

Also, the delete button, because it also not allow the admin to delete the bot. so what's the point to put this delete button there.

Relevant logs:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Admin tab's users view and reproduce the behavior with an installed app or bot. Trace the edit and delete controls for these users, then verify that unsupported actions are disabled or that only the permitted fields can be changed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.